Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Centos 7 EOL blog post #2937

Merged
merged 8 commits into from
Jul 4, 2024
Merged

Create Centos 7 EOL blog post #2937

merged 8 commits into from
Jul 4, 2024

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 3, 2024

Description of change

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit b263232
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/66864fed6177dd00083e2954
😎 Deploy Preview https://deploy-preview-2937--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gdams gdams linked an issue Jul 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.34%. Comparing base (663d889) to head (b263232).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2937   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files          90       90           
  Lines        6970     6970           
  Branches      611      611           
=======================================
  Hits         6924     6924           
  Misses         46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdams gdams marked this pull request as ready for review July 3, 2024 14:09
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions

@gdams
Copy link
Member Author

gdams commented Jul 3, 2024

@sxa updated PTAL

@gdams gdams requested a review from sxa July 3, 2024 15:57
@karianna
Copy link
Contributor

karianna commented Jul 4, 2024

@gdams shellcheck doesn't like the date format

@gdams
Copy link
Member Author

gdams commented Jul 4, 2024

@gdams shellcheck doesn't like the date format

fixed, it was actually the regex in the command that we use to scrape the date that was incorrect

@gdams gdams merged commit 47746af into main Jul 4, 2024
18 checks passed
@gdams gdams deleted the centos7-EOL branch July 4, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog post on CentOS7 container deprecation (tag removal)
3 participants